[LLVM] VectorType::get with two parameters is deprecated in LLVM 11+ #5984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In LLVM 11+ the distinction between fixed and scalable vector types has become more explicit. Before the introduction of scalable vector types VectorType::get(e,n) created what is now a fixed vector type. With the addition of scalable types, it is recommended to use FixedVectorType and ScalableVectorType classes directly. Alternatively, there is a VectorType::get that accepts a 3rd parameter indicating whether the type should be fixed or scalable. Using the older VectorType::get that implicitly assumes the fixed type is deprecated and LLVM now generates a warning. Change calls to VectorType::get to FixedVectorType::get to avoid compilation warnings.
tqchen
approved these changes
Jul 2, 2020
junrushao
approved these changes
Jul 2, 2020
|
Thanks @kparzysz-quic @junrushao1994 ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jul 14, 2020
…pache#5984) In LLVM 11+ the distinction between fixed and scalable vector types has become more explicit. Before the introduction of scalable vector types VectorType::get(e,n) created what is now a fixed vector type. With the addition of scalable types, it is recommended to use FixedVectorType and ScalableVectorType classes directly. Alternatively, there is a VectorType::get that accepts a 3rd parameter indicating whether the type should be fixed or scalable. Using the older VectorType::get that implicitly assumes the fixed type is deprecated and LLVM now generates a warning. Change calls to VectorType::get to FixedVectorType::get to avoid compilation warnings.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 14, 2020
…pache#5984) In LLVM 11+ the distinction between fixed and scalable vector types has become more explicit. Before the introduction of scalable vector types VectorType::get(e,n) created what is now a fixed vector type. With the addition of scalable types, it is recommended to use FixedVectorType and ScalableVectorType classes directly. Alternatively, there is a VectorType::get that accepts a 3rd parameter indicating whether the type should be fixed or scalable. Using the older VectorType::get that implicitly assumes the fixed type is deprecated and LLVM now generates a warning. Change calls to VectorType::get to FixedVectorType::get to avoid compilation warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LLVM 11+ the distinction between fixed and scalable vector types has become more explicit. Before the introduction of scalable vector types
VectorType::get(e,n)created what is now a fixed vector type. With the addition of scalable types, it is recommended to useFixedVectorTypeandScalableVectorTypeclasses directly. Alternatively, there is aVectorType::getthat accepts a 3rd parameter indicating whether the type should be fixed or scalable.Using the older
VectorType::getthat implicitly assumes the fixed type is deprecated and LLVM now generates a warning.Change calls to
VectorType::gettoFixedVectorType::getto avoid compilation warnings.