[PatternLang] Don't rewrite expressions used outside of the pattern #5930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comaniac
reviewed
Jun 25, 2020
| T2 = BN[0] | ||
| add = T1 + T2 | ||
|
|
||
| assert tuple_get_item_node.partition(add) == add |
There was a problem hiding this comment.
Two questions to this test case:
- Should we use
structural_equalhere? - Does that mean we do not even treat
BN -> T2as a match anymore?
There was a problem hiding this comment.
Partitioning either path is invalid, since either side would need intermediate nodes from the other, so we expect the original expression to come back unchanged, thus the ==. We treat it as a match, but we don't treat it as something we can independently rewrite.
There was a problem hiding this comment.
Ah I see. That makes sense.
| relu = relay.op.nn.relu(conv2d) | ||
| out = relu + conv2d | ||
|
|
||
| assert pattern.partition(out) == out |
There was a problem hiding this comment.
Again, fusing the conv and relu would make the rest of the expr invalid, so we expect the expr to come back unchanged.
comaniac
approved these changes
Jun 26, 2020
tqchen
approved these changes
Jun 26, 2020
|
Thanks @mbrookhart , Thanks @comaniac for reviewing |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 30, 2020
…pache#5930) * Don't rewrite expressions used outside of the pattern * add comments
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
…pache#5930) * Don't rewrite expressions used outside of the pattern * add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@comaniac
While investigating #5928, I discovered an issue where the pattern language would rewrite expressions used outside of the pattern, this prevents that issue, but doesn't fix #5928