Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay]Allow every runtime module to handle constants #5885

Merged
merged 2 commits into from
Jun 23, 2020
Merged

[Relay]Allow every runtime module to handle constants #5885

merged 2 commits into from
Jun 23, 2020

Conversation

comaniac
Copy link
Contributor

Per discussion in #5884, this PR makes the following improvements:

  • Allow any runtime with get_symbol and get_const_vars to use the unified mechanism of constant processing.
  • We will have a JSON runtime PR later this week to demonstrate how a customized runtime works with this mechanism.

cc @zhiics @mbaret

@comaniac comaniac mentioned this pull request Jun 22, 2020
Merged
junrushao
junrushao approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbaret mbaret mentioned this pull request Jun 23, 2020
Closed
@mbaret
Copy link
Contributor

mbaret commented Jun 23, 2020

Given some modules don't use this mechanism, should we find a way to suppress this warning?
https://github.com/apache/incubator-tvm/blob/b94e8b7290c5ced98728e730634ec73727c53c51/src/runtime/graph/graph_runtime.cc#L93
I'm noticing that I'm getting spammed with it now.

@zhiics
Copy link
Member

zhiics commented Jun 23, 2020

@mbaret this should be handled later by changing the way to initialize graph runtime in different PRs.

@zhiics zhiics merged commit 8108f59 into apache:master Jun 23, 2020
@zhiics
Copy link
Member

zhiics commented Jun 23, 2020

thanks @comaniac @mbaret @junrushao1994

@comaniac comaniac deleted the update_source_module branch June 23, 2020 23:50
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 30, 2020
@comaniac
[Relay]Allow every runtime module to handle constants (apache#5885)
ac2b566 
* update source module

* address comment
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Jul 2, 2020
@comaniac @zhiics
[Relay]Allow every runtime module to handle constants (apache#5885)
dda369d 
* update source module

* address comment
@ZihengJiang ZihengJiang mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbaret mbaret mbaret approved these changes

@junrushao junrushao junrushao approved these changes

@zhiics zhiics zhiics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@comaniac @mbaret @zhiics @junrushao