Fail early before running invalid dynamic graphs #5856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthesun
reviewed
Jun 20, 2020
|
Thanks @mbrookhart @zhiics |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 30, 2020
* fail early before running invalid dynamic graphs * fix an issue with the VM comment
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
* fail early before running invalid dynamic graphs * fix an issue with the VM comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zhiics
In testing dynamic graphs, I've run into some pretty gnarly error messages deep in the memory planner for graph runtime or deep in nested packed function calls in the VM. In a "fail early" philosphy, This PR adds an earlier check for dynamic shapes and throws with a hopefully more useful error message. Once we have heterogenous execution working on the VM, we can relax the check on the VM side.
Thanks!