[RELAY][VM] Add shape_of instruction #5855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
approved these changes
Jun 23, 2020
|
cc @mbrookhart |
icemelon
reviewed
Jun 23, 2020
mbrookhart
reviewed
Jun 23, 2020
icemelon
reviewed
Jun 23, 2020
tqchen
requested changes
Jun 26, 2020
python/tvm/relay/op/dialect/vm.py
Outdated
| @@ -0,0 +1,35 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
| # or more contributor license agreements. See the NOTICE file | |||
There was a problem hiding this comment.
Let us simply use relay.op.vm and mark it as a dialect in the comment. Since QNN is also a dialect but does not belong to the dialect namespace
There was a problem hiding this comment.
Thanks for pointing out. I changed it to relay.op.vm. Maybe we should have such a namespace in the long run? Likely, we can have dialect.vm, dialect.memory, dialect.qnn, etc.
icemelon
reviewed
Jun 26, 2020
|
@tqchen could you please take another look? |
tqchen
approved these changes
Jun 28, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 30, 2020
zhiics
added a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a VM instruction
ShapeOfto get the shape of a tensor at runtime. This instruction is always executed on CPU as there is no computation required.cc @icemelon9 @jroesch @wweic