[FIX] Recover global state after test_util.py #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Jun 16, 2020
In test_util.py, a program exit is simulated to test that the error throwing behaviour is accurate. Unforunately, this also deletes necessary global state and so all subsequent tests that run and use tempdir throw the same error. This patch is a simple fix to restore the global state at the end of the test. Change-Id: I62fef46167e47f6af43271e2ce1db30f54857647
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 30, 2020
In test_util.py, a program exit is simulated to test that the error throwing behaviour is accurate. Unforunately, this also deletes necessary global state and so all subsequent tests that run and use tempdir throw the same error. This patch is a simple fix to restore the global state at the end of the test. Change-Id: I62fef46167e47f6af43271e2ce1db30f54857647
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
In test_util.py, a program exit is simulated to test that the error throwing behaviour is accurate. Unforunately, this also deletes necessary global state and so all subsequent tests that run and use tempdir throw the same error. This patch is a simple fix to restore the global state at the end of the test. Change-Id: I62fef46167e47f6af43271e2ce1db30f54857647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In test_util.py, a program exit is simulated to test that the error throwing behaviour is accurate. Unforunately, this also deletes necessary global state and so all subsequent tests that run and use tempdir throw the same error.
This patch is a simple fix to restore the global state at the end of the test.