[REFACTOR][Relay] Migrate Id ObjectRef to not-null #5748
Conversation
| @@ -152,6 +152,9 @@ class Var; | |||
| /*! \brief Container for Var */ | |||
| class VarNode : public ExprNode { | |||
| public: | |||
| VarNode(Id vid, Type type_annotation) : vid(vid), type_annotation(type_annotation) {} | |||
| VarNode() : vid("") {} | |||
There was a problem hiding this comment.
The not-null that involves composite objects are more complicated and this is not necessarily the best approach, let us wait a bit before we find a better solution
There was a problem hiding this comment.
The not-null that involves composite objects are more complicated and this is not necessarily the best approach, let us wait a bit before we find a better solution
@tqchen : Thanks! I also felt that this is not best way. We might have to change Node registration framework i believe. Will wait for your future guidance!
|
This would be a baseline reference for other Relay nodes. Please suggest the best way to cover this! Thanks! |
|
@tqchen Seems that some changes in my WIP PR have affected this PR https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-5748/1/pipeline. We probably should "make clean" before build wasm |
|
@junrushao1994 good pt, can you send another PR? |
|
Do we have conclusions yet on what the best way is to support not-null with composite objects? |
|
@junrushao1994 I will try to send a proposal around UnsafeNull |
Refer #5318
@tqchen, @jroesch, @zhiics, @junrushao1994 : Please help review, Thanks!