[RPC] Call sync in CopyFromRemote and CopyToRemote #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what's the justification for doing this just over RPC sessions? |
|
@areusch We only do it for CopyFromRemote and CopyToRemote. In both cases, we(user or rpc server) can choose to allocate temp meomory from the arena, which will become invalid after the response. The user do not guarantee these byte arrays stays alive after the call ends. So that is why explicit sync is needed here. For DeviceAPI::CopyDataFromTo, we do not run the sync, since the resources are NDArrays managed by the remote user, and the remote user can choose to call sync after the copy |
tqchen
changed the title
areusch
approved these changes
May 5, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 9, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 18, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @tmoreau89 @areusch @ZihengJiang