[TFLite] Model importer to be compatible with tflite 2.1.0 #5497

tmoreau89 · 2020-05-01T18:41:19Z

Summary of changes:

Make tflite importer compatible with old tflite (1.13) and 2.1.0
Update from_tflite.py tutorial to pip install tflite from PyPI repo for convenience, and update to 2.1.0

Tested from_tflite.py on environment with TFLite 2.1.0 and 1.13 to make sure we don't break backwards compatibility.

tmoreau89 · 2020-05-01T18:42:07Z

CC @tqchen @FrozenGene @u99127

tmoreau89 · 2020-05-01T19:05:16Z

@michalpiszczek

u99127

Thanks for this - I've been scratching my head off and on about this in some of the failures I've been seeing with running through some of the tutorials.

Didn't realize there could be breaking API changes in tflite. !

Ramana

tests/python/frontend/tflite/test_forward.py

u99127 · 2020-05-01T21:03:15Z

Summary of changes:
* Make tflite importer compatible with old tflite (1.13) and 2.1.0

* Update `from_tflite.py` tutorial to pip install tflite from PyPI repo for convenience, and update to 2.1.0
Tested from_tflite.py on environment with TFLite 2.1.0 and 1.13 to make sure we don't break backwards compatibility.

Do we need to keep compatibility with both tflite 2.1.0 and 1.13.0 or should we think about another CI pipeline for 1.13 compatibility ?

tmoreau89 · 2020-05-01T22:24:43Z

I think we should adopt/embrace 2.1.0 but not break existing deployments that depend on 1.13 IMO

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

apivovarov · 2020-08-18T19:23:53Z

tutorials/frontend/from_tflite.py

-    wget https://github.com/FrozenGene/tflite/releases/download/v1.13.1/tflite-1.13.1-py2-none-any.whl
-    pip install -U tflite-1.13.1-py2-none-any.whl --user
+    # install tflite
+    pip install tflite=2.1.0 --user


@tmoreau89 pip command fails. We need to use == instead of =.

tflite 2.1.0 compatibility

9fd6e0d

tmoreau89 requested a review from FrozenGene May 1, 2020 18:41

lint fix

4622f27

fix tflitemodel attribute error

d9b058c

u99127 suggested changes May 1, 2020

View reviewed changes

tests/python/frontend/tflite/test_forward.py Outdated Show resolved Hide resolved

fix

409dd83

tqchen approved these changes May 2, 2020

View reviewed changes

tqchen merged commit 8599f7c into apache:master May 2, 2020

tmoreau89 deleted the tflitefix branch May 2, 2020 22:40

Laurawly pushed a commit to Laurawly/tvm-1 that referenced this pull request May 9, 2020

[TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497)

d77ed02

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 19, 2020

[SDK] compatible with tflite 2.1.0

c66a9e4

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 19, 2020

[SDK] compatible with tflite 2.1.0

331f2b8

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 19, 2020

[SDK] compatible with tflite 2.1.0

2e8e1ba

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 19, 2020

[SDK] compatible with tflite 2.1.0

9e2ee7f

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 20, 2020

[SDK] compatible with tflite 2.1.0

574e723

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 20, 2020

[SDK] compatible with tflite 2.1.0

436cdbc

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 20, 2020

[SDK] compatible with tflite 2.1.0

690db97

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 21, 2020

[SDK] compatible with tflite 2.1.0

ba8fa5e

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 22, 2020

[SDK] compatible with tflite 2.1.0

05611f0

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 24, 2020

[SDK] compatible with tflite 2.1.0

688814e

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 26, 2020

[SDK] compatible with tflite 2.1.0

13c001c

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 26, 2020

[SDK] compatible with tflite 2.1.0

ffe739f

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 27, 2020

[SDK] compatible with tflite 2.1.0

5b1ed7a

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 28, 2020

[SDK] compatible with tflite 2.1.0

1c78c85

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request May 29, 2020

[SDK] compatible with tflite 2.1.0

b043e37

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jun 1, 2020

[SDK] compatible with tflite 2.1.0

aaf87c4

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jun 30, 2020

[SDK] compatible with tflite 2.1.0

734d9c8

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 1, 2020

[SDK] compatible with tflite 2.1.0

de6e5a5

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 1, 2020

[SDK] compatible with tflite 2.1.0

93e63ee

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 2, 2020

[SDK] compatible with tflite 2.1.0

03d2d87

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 2, 2020

[SDK] compatible with tflite 2.1.0

24210c6

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 2, 2020

[SDK] compatible with tflite 2.1.0

ecfa27d

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 2, 2020

[SDK] compatible with tflite 2.1.0

0ef5351

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 2, 2020

[SDK] compatible with tflite 2.1.0

ffd8529

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 2, 2020

[SDK] compatible with tflite 2.1.0

d2af500

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 3, 2020

[SDK] compatible with tflite 2.1.0

5a50b59

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 3, 2020

[SDK] compatible with tflite 2.1.0

13f8310

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 3, 2020

[SDK] compatible with tflite 2.1.0

f82a4eb

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 3, 2020

[SDK] compatible with tflite 2.1.0

76ade4b

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 3, 2020

[SDK] compatible with tflite 2.1.0

d7477eb

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 3, 2020

[SDK] compatible with tflite 2.1.0

49a0a1d

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 3, 2020

[SDK] compatible with tflite 2.1.0

3e4fcf5

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 6, 2020

[SDK] compatible with tflite 2.1.0

e7f64de

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 7, 2020

[SDK] compatible with tflite 2.1.0

1f4feba

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 7, 2020

[SDK] compatible with tflite 2.1.0

66d5bfb

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 9, 2020

[SDK] compatible with tflite 2.1.0

968aeef

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 9, 2020

[SDK] compatible with tflite 2.1.0

00c157d

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 9, 2020

[SDK] compatible with tflite 2.1.0

a8598da

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 10, 2020

[SDK] compatible with tflite 2.1.0

dd16a65

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 10, 2020

[SDK] compatible with tflite 2.1.0

01a4b36

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 13, 2020

[SDK] compatible with tflite 2.1.0

b07a52b

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 13, 2020

[SDK] compatible with tflite 2.1.0

fa93499

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 13, 2020

[SDK] compatible with tflite 2.1.0

9f0e67d

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

windclarion pushed a commit to windclarion/incubator-tvm that referenced this pull request Jul 13, 2020

[SDK] compatible with tflite 2.1.0

6772304

see commit 8599f7c [TFLite] Model importer to be compatible with tflite 2.1.0 (apache#5497) Signed-off-by: Taikang Hu <[email protected]>

apivovarov reviewed Aug 18, 2020

View reviewed changes

ZihengJiang mentioned this pull request Sep 25, 2020

TVM v0.7 Release Note Candidate #6486

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TFLite] Model importer to be compatible with tflite 2.1.0 #5497

[TFLite] Model importer to be compatible with tflite 2.1.0 #5497

tmoreau89 commented May 1, 2020

tmoreau89 commented May 1, 2020

tmoreau89 commented May 1, 2020

u99127 left a comment

u99127 commented May 1, 2020

tmoreau89 commented May 1, 2020

apivovarov Aug 18, 2020

[TFLite] Model importer to be compatible with tflite 2.1.0 #5497

[TFLite] Model importer to be compatible with tflite 2.1.0 #5497

Conversation

tmoreau89 commented May 1, 2020

tmoreau89 commented May 1, 2020

tmoreau89 commented May 1, 2020

u99127 left a comment

Choose a reason for hiding this comment

u99127 commented May 1, 2020

tmoreau89 commented May 1, 2020

apivovarov Aug 18, 2020

Choose a reason for hiding this comment