Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TFLite Runtime] Add TFLite Runtime dependencies to CI CPU docker build #5437

Merged
merged 10 commits into from
Apr 27, 2020

Conversation

michalpiszczek
Copy link
Contributor

This PR contains only the docker build changes needed to re-enable the tests in: #5436.

@michalpiszczek michalpiszczek changed the title [TFLite Runtime] Add TFLite Runtime dependencies to CI CPU docker build [TFLite Runtime] Add TFLite Runtime deps to CI CPU docker build Apr 24, 2020
@michalpiszczek michalpiszczek changed the title [TFLite Runtime] Add TFLite Runtime deps to CI CPU docker build [TFLite Runtime] Add TFLite Runtime dependencies to CI CPU docker build Apr 24, 2020
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Build the TFLite static library, necessary for building with TFLite ON.
# The library is built at:
# tensorflow/tensorflow/lite/tools/make/gen/*/lib/libtensorflow-lite.a.
git clone https://github.com/tensorflow/tensorflow --branch=r2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not 2.1.0 which is the latest stable version and what we install in the tree. I don’t think it’s worth the version skew.

Ramana

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@u99127 Good catch, thank you. I noticed your PR updating the version yesterday but I forgot I was specifying 2.0 here. Will update :)

@tqchen tqchen merged commit 17cd27d into apache:master Apr 27, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 9, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 18, 2020
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants