Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Frontend][Pytorch] Fixed ConvTranspose2D parsing #5157

Merged
merged 4 commits into from
Mar 28, 2020

Conversation

jwfromm
Copy link
Contributor

@jwfromm jwfromm commented Mar 27, 2020

There were some small bugs in the new pytorch frontend when parsing conv2d_transpose. This PR corrects them and adds related tests.

@jwfromm
Copy link
Contributor Author

jwfromm commented Mar 27, 2020

@masahi @alexwong can you take a look at this PR?

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jwfromm ! @masahi makes a good point; once the tests are further streamlined, I'll go ahead and approve.

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwfromm LGTM!

@masahi masahi merged commit 9c80662 into apache:master Mar 28, 2020
@masahi
Copy link
Member

masahi commented Mar 28, 2020

Thanks @jwfromm @tmoreau89

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
* Fixed conv transpose parsing.

* small format change.

* Chage test module names.

* Simplified test syntax.
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
* Fixed conv transpose parsing.

* small format change.

* Chage test module names.

* Simplified test syntax.
@jwfromm jwfromm deleted the torch_bug branch April 12, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants