[RELAY] Remove kCompiler attr from ext mod #5028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions in external modules kept their kCompiler attribute which means UseDefaultCompiler returns false. This prevents you from being able to run any passes on these external modules. By setting this attribute to 'default' when we add the function to the external module, we allow for passes to be run external modules. Change-Id: Ia60de3f0b0db9101738eac407aca4913fad9525a
tqchen
requested changes
Mar 20, 2020
|
cc @zhiics |
tqchen
added
status: need review
status: need update
|
Sorry. I totally missed this PR. |
zhiics
reviewed
Mar 24, 2020
| @@ -627,6 +627,7 @@ class CompileEngineImpl : public CompileEngineNode { | |||
| const tvm::tir::StringImmNode* symbol_name = ext_symbol.as<tvm::tir::StringImmNode>(); | |||
| CHECK(symbol_name) << "No external symbol is set for:\n" << AsText(src_func, false); | |||
| auto gv = GlobalVar(symbol_name->value); | |||
| src_func = WithAttr(src_func, attr::kCompiler, tir::StringImmNode::make("default")); | |||
There was a problem hiding this comment.
Now you should not give it "default" but a null string ObjectRef, so that the returned value is not defined
There was a problem hiding this comment.
Also, inorder to use CoW, you may want to use src_func = WithAttr(std::move(src_func), ...)
|
please followup, or close the PR if it is superseded by the later ones |
|
Let's close it. I think it is not needed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions in external modules kept their kCompiler attribute which means UseDefaultCompiler returns false. This prevents you from being able to run any passes on these external modules. By setting this attribute to 'default' when we add the function to the external module, we allow for passes to be run external modules.