[Refactor][Relay Build] refactor build module to take IRModule #4988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiics
force-pushed
the
build_mod
branch
2 times, most recently
from
5d662d1 to
8376093
Compare
comaniac
approved these changes
Mar 5, 2020
|
Yeah, Python side still accepts |
|
I see. That makes sense. |
tqchen
approved these changes
Mar 5, 2020
|
LGTM. Should we also update the tutorials? |
|
@wweic Its okay. Tutorials have already used module. |
wweic
approved these changes
Mar 5, 2020
|
@zhiics seems this change breaks the master ci, please look into it |
|
Okay. I will. Thanks for reminding. |
|
hmm, this actually revealed that the gcn tutorial didn't pass mod. We need to bind params when adding the function to the mod. Interestingly, it didn't fail for the last two runs before merging. #4994 |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
zhiics
added a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors relay build_module interfaces to accept IRModules instead of Function. This can help external codegen that may need to lift functions into the global scope.
Many tests in the codebase have already passed IRModule to
relay.build, so no additional unit test is added in this PR.A follow up PR will be sent to add the outlining and inlining of subgraphs/sub-functions that are supported by external codegen.
cc @comaniac @icemelon9 @jroesch @tqchen @wweic