Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Ops in relay.op.contrib.* #4942

Merged
merged 4 commits into from
Feb 27, 2020
Merged

Conversation

comaniac
Copy link
Contributor

@comaniac comaniac commented Feb 26, 2020

According to the discussion in #4933, we should move the level 10 ops out of relay.op.contrib.

This PR moves adaptive_max_pool2d and adaptive_avg_pool2d to relay.op.nn; ndarray_size to relay.op.tensor.

In addition, I keep relay.op.contrib as a placeholder for #4933.

cc @zhiics @icemelon9 @kevinthesun

python/tvm/relay/op/nn/_nn.py Outdated Show resolved Hide resolved
python/tvm/relay/op/nn/_nn.py Show resolved Hide resolved
@kevinthesun kevinthesun merged commit 81ff061 into apache:master Feb 27, 2020
@kevinthesun
Copy link
Contributor

Thanks @comaniac @icemelon9 @zhiics

@comaniac comaniac deleted the move_contrib_op branch February 27, 2020 20:58
@tqchen
Copy link
Member

tqchen commented Feb 27, 2020

@comaniac This PR introduces quite a few doc warnings, please fix them, then we can enable the build checks

@tqchen
Copy link
Member

tqchen commented Feb 27, 2020

@comaniac
Copy link
Contributor Author

Oops. Sorry for that. Will do.

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
* move contrib

* lint

* address comment

* address comment
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
* move contrib

* lint

* address comment

* address comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants