-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TFLITE][FRONTEND]Reduce_any op parsing support #4926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyc-ruiker
reviewed
Feb 24, 2020
siju-samuel
force-pushed
the
tflite_reduce_any
branch
from
February 24, 2020 08:00
a4d9023
to
c90efcd
Compare
wyc-ruiker
reviewed
Feb 24, 2020
siju-samuel
force-pushed
the
tflite_reduce_any
branch
2 times, most recently
from
February 27, 2020 03:24
77e897f
to
9267f54
Compare
wyc-ruiker
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
siju-samuel
force-pushed
the
tflite_reduce_any
branch
from
March 3, 2020 03:41
9267f54
to
50f603f
Compare
inadob
suggested changes
Mar 3, 2020
@@ -1152,6 +1165,8 @@ def test_all_reduce(): | |||
_test_forward_reduce_quantized(_test_reduce_mean) | |||
_test_forward_reduce(_test_reduce_prod) | |||
_test_forward_reduce(_test_reduce_sum) | |||
if package_version.parse(tf.VERSION) >= package_version.parse('1.14.0'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support for boolean data type was added in tf 1.15 so, please, change the check
inadob
approved these changes
Mar 4, 2020
LGTM |
siju-samuel
force-pushed
the
tflite_reduce_any
branch
from
March 11, 2020 12:05
ca3b03d
to
2209d53
Compare
FrozenGene
approved these changes
Mar 12, 2020
Thanks @siju-samuel @inadob @wyc-ruiker merged |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* [TFLITE][FRONTEND]Reduce_any op parsing support * Testcase check added to run in tf version above 1.14.0 & review comments * Review comment, checked updated to 1.15
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* [TFLITE][FRONTEND]Reduce_any op parsing support * Testcase check added to run in tf version above 1.14.0 & review comments * Review comment, checked updated to 1.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@FrozenGene @u99127 @kevinthesun Please help to review. Thanks.