Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TFLITE][FRONTEND]Reduce_any op parsing support #4926

Merged
merged 3 commits into from
Mar 12, 2020

Conversation

siju-samuel
Copy link
Member

@FrozenGene @u99127 @kevinthesun Please help to review. Thanks.

@siju-samuel siju-samuel force-pushed the tflite_reduce_any branch 2 times, most recently from 77e897f to 9267f54 Compare February 27, 2020 03:24
Copy link
Contributor

@wyc-ruiker wyc-ruiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1152,6 +1165,8 @@ def test_all_reduce():
_test_forward_reduce_quantized(_test_reduce_mean)
_test_forward_reduce(_test_reduce_prod)
_test_forward_reduce(_test_reduce_sum)
if package_version.parse(tf.VERSION) >= package_version.parse('1.14.0'):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for boolean data type was added in tf 1.15 so, please, change the check

@inadob
Copy link
Contributor

inadob commented Mar 4, 2020

LGTM

@FrozenGene
Copy link
Member

Thanks @siju-samuel @inadob @wyc-ruiker merged

@FrozenGene FrozenGene merged commit a950536 into apache:master Mar 12, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
* [TFLITE][FRONTEND]Reduce_any op parsing support

* Testcase check added to run in tf version above 1.14.0 & review comments

* Review comment, checked updated to 1.15
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
* [TFLITE][FRONTEND]Reduce_any op parsing support

* Testcase check added to run in tf version above 1.14.0 & review comments

* Review comment, checked updated to 1.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants