Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] move vm.py under runtime and adt to runtime.container.py #4855

Merged
merged 5 commits into from
Feb 11, 2020

Conversation

zhiics
Copy link
Member

@zhiics zhiics commented Feb 10, 2020

#4854
This PR moves vm.py under the runtime folder and adt to runtime.container

cc @tqchen @wweic @icemelon9 @jroesch

@tqchen tqchen added the status: need update need update based on feedbacks label Feb 10, 2020
src/runtime/vm/vm.cc Outdated Show resolved Hide resolved
python/tvm/runtime/vm.py Outdated Show resolved Hide resolved
python/tvm/runtime/vm.py Outdated Show resolved Hide resolved
@tqchen
Copy link
Member

tqchen commented Feb 11, 2020

cc @icemelon9 please also help to take a look

Copy link
Member

@tqchen tqchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some final nits

python/tvm/runtime/vm.py Outdated Show resolved Hide resolved
python/tvm/runtime/vm.py Show resolved Hide resolved
@tqchen tqchen merged commit 502cf26 into apache:master Feb 11, 2020
@tqchen
Copy link
Member

tqchen commented Feb 11, 2020

Thanks @zhiics !

@tqchen tqchen added status: accepted and removed status: need update need update based on feedbacks labels Feb 11, 2020
@zhiics zhiics deleted the container branch February 11, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants