[Frontend][TFLite] Add MIRROR_PAD operator #4822
Conversation
| # the quantized form MirrorPad is not yet implemented in TFLite. | ||
| if self.is_quantized(op): | ||
| raise tvm.error.OpNotImplemented( | ||
| 'TFlite quantized MIRROR_PAD operator is not supported yet.') |
There was a problem hiding this comment.
Pedantry : A not implemented error suggests to me as a user that the support exists in the tflite tooling but the TVM stack has not yet implemented the support i.e. the tflite tooling can't yet produce the mirror_pad operation, do we need a different notification here actually asking the user to report an issue asking for a feature to be added ?
There was a problem hiding this comment.
I think this exception will not be triggered when quantized MIRROR_PAD is not implemented by TFLite. If the exception is triggered, it certainly means the TVM stack doesn't support quantized MIRROR_PAD.
|
LGTM |
@inadob Could you do the approve operation as this guide? https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly Thanks! |
|
Thanks @wyc-ruiker @inadob It is merged now. |
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
@FrozenGene @inadob @anijain2305 @apivovarov Could you please help to review this patch.