[FFI][Windows] Parse additional exception strings #4785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorrill
changed the title
soiferj
approved these changes
Jan 29, 2020
|
Clean fix was all you. I just did the clerical work. Thanks man! |
FrozenGene
approved these changes
Jan 30, 2020
|
@soiferj if you have no other comment, please approve this change according to this doc: https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly |
|
@FrozenGene that’s how I approved the changes yesterday! Above my comment I see the message “soiferj approved these changes”. Feel free to check in. |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #4780
This adds parsing for exceptions that are formatted like: "
AttributeError: relay.Op object has no attributed attrs"@soiferj