[Relay][Frontend][ONNX] Broadcast condition, x, and y for Where op #4774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwfromm
approved these changes
Jan 25, 2020
jroesch
approved these changes
Jan 27, 2020
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
…pache#4774) * ONNX frontend broadcast condition * fix * fix style Co-authored-by: Jon Soifer <[email protected]>
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
…pache#4774) * ONNX frontend broadcast condition * fix * fix style Co-authored-by: Jon Soifer <[email protected]>
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
…pache#4774) * ONNX frontend broadcast condition * fix * fix style Co-authored-by: Jon Soifer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONNX's
Whereoperator can broadcast the condition, x, and y tensors. The current implementation will only broadcast x and y.This change will try to find the best shape to broadcast to (longest and doesn't have 1 as a dimension), and will broadcast all tensors to that shape.
@jwfromm would you be able to take a look?