Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR][TYPE] Finish move all types to IR. #4746

Merged
merged 2 commits into from
Jan 20, 2020
Merged

[REFACTOR][TYPE] Finish move all types to IR. #4746

merged 2 commits into from
Jan 20, 2020

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Jan 20, 2020

  • Move definition of Ref and TensorType to ir
  • Move type_functor.h to public header.
  • Rename RefType -> RelayRefType for clarity.

@tqchen
[REFACTOR][TYPE] Finish move all types to IR.
1567016 
- Move definition of Ref and TensorType to ir
- Move type_functor.h to public header.
- Rename RefType -> RelayRefType for clarity.
@tqchen
Copy link
Member Author

tqchen commented Jan 20, 2020

cc @wweic @MarisaKirisame @jroesch @ZihengJiang

MarisaKirisame
MarisaKirisame approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@MarisaKirisame MarisaKirisame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen tqchen mentioned this pull request Jan 20, 2020
Merged
@tqchen tqchen merged commit 2c0c184 into apache:master Jan 20, 2020
@tqchen
Copy link
Member Author

tqchen commented Jan 20, 2020

Thanks @ZihengJiang @MarisaKirisame

@tqchen tqchen deleted the type branch February 10, 2020 19:24
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
@tqchen @alexwong
[REFACTOR][TYPE] Finish move all types to IR. (apache#4746)
f8b7028 
* [REFACTOR][TYPE] Finish move all types to IR.

- Move definition of Ref and TensorType to ir
- Move type_functor.h to public header.
- Rename RefType -> RelayRefType for clarity.

* Add atol
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
@tqchen @alexwong
[REFACTOR][TYPE] Finish move all types to IR. (apache#4746)
cffdcb1 
* [REFACTOR][TYPE] Finish move all types to IR.

- Move definition of Ref and TensorType to ir
- Move type_functor.h to public header.
- Rename RefType -> RelayRefType for clarity.

* Add atol
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
@tqchen @zhiics
[REFACTOR][TYPE] Finish move all types to IR. (apache#4746)
61b8461 
* [REFACTOR][TYPE] Finish move all types to IR.

- Move definition of Ref and TensorType to ir
- Move type_functor.h to public header.
- Rename RefType -> RelayRefType for clarity.

* Add atol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZihengJiang ZihengJiang ZihengJiang approved these changes

@MarisaKirisame MarisaKirisame MarisaKirisame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tqchen @MarisaKirisame @ZihengJiang