[REFACTOR] relay::Module Def -> TypeDef #4665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The term Def was not very clear about what is the object of interest(could be function def or type def). Changes the term to TypeDef to be more explicit.
wweic
approved these changes
Jan 9, 2020
Co-Authored-By: Wei Chen <[email protected]>
|
Thanks @wweic |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
* [REFACTOR] relay::Module Def -> TypeDef The term Def was not very clear about what is the object of interest(could be function def or type def). Changes the term to TypeDef to be more explicit. * Update include/tvm/relay/module.h Co-Authored-By: Wei Chen <[email protected]> Co-authored-by: Wei Chen <[email protected]>
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
* [REFACTOR] relay::Module Def -> TypeDef The term Def was not very clear about what is the object of interest(could be function def or type def). Changes the term to TypeDef to be more explicit. * Update include/tvm/relay/module.h Co-Authored-By: Wei Chen <[email protected]> Co-authored-by: Wei Chen <[email protected]>
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
* [REFACTOR] relay::Module Def -> TypeDef The term Def was not very clear about what is the object of interest(could be function def or type def). Changes the term to TypeDef to be more explicit. * Update include/tvm/relay/module.h Co-Authored-By: Wei Chen <[email protected]> Co-authored-by: Wei Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term Def was not very clear about what is the object of interest(could be function def or type def).
Changes the term to TypeDef to be more explicit.
cc @jroesch @wweic