[Bugfix] fskip of EliminateCommonSubexpr cannot always return false #4620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fskip returns false at the end of PackedFunc, discards return true in 'cast' case
yuliujq
changed the title
yuliujq
changed the title
yuliujq
changed the title
|
A little fix for fskip in EliminateCommonSubexpr, it will not return false in 'cast' case. |
|
could you take a look at the ci error? |
|
also can we have a test case? |
yuliujq
commented
Jan 7, 2020
| @@ -318,6 +318,7 @@ class RelayBuildModule : public runtime::ModuleNode { | |||
| pass_seqs.push_back(transform::SimplifyInference()); | |||
| PackedFunc fskip = PackedFunc([](TVMArgs args, TVMRetValue* rv) { | |||
| Expr expr = args[0]; | |||
| *rv = false; | |||
There was a problem hiding this comment.
Default return false
vinx13
approved these changes
Jan 11, 2020
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
…pache#4620) * 'fskip' will not always return false fskip returns false at the end of PackedFunc, discards return true in 'cast' case * Update build_module.cc
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
…pache#4620) * 'fskip' will not always return false fskip returns false at the end of PackedFunc, discards return true in 'cast' case * Update build_module.cc
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
…pache#4620) * 'fskip' will not always return false fskip returns false at the end of PackedFunc, discards return true in 'cast' case * Update build_module.cc
This was referenced Jun 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, fskip returns false at the end of PackedFunc, discards return true in 'cast' case