Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Bring Your Own Codegen Guide -- Part 1 #4602

Merged
merged 6 commits into from
Jan 16, 2020

Conversation

comaniac
Copy link
Contributor

After the relevant PRs merged, we This doc provides a detail guideline about how to implement your own codegen for TVM. Ultimately this guide will have three parts:

  1. How to implement a codegen that generates C code for your platform. -- This PR.

  2. How to implement a codegen that generates any other graph representations (e.g., JSON), and implement a customized TVM runtime module to execute that representation.

  3. How to annotate a Relay program to trigger the implemented codegen and runtime.

cc @zhiics @tqchen @masahi

@zhiics
Copy link
Member

zhiics commented Dec 30, 2019

CC @u99127 @soiferj who may also be interested.

docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
@comaniac
Copy link
Contributor Author

comaniac commented Jan 5, 2020

@tqchen @masahi @u99127 @soiferj would you mind helping review this document? Thanks.

@u99127
Copy link
Contributor

u99127 commented Jan 6, 2020

Sorry been on vacation and just starting to catch up. I'll need a day or so to read this.

@comaniac
Copy link
Contributor Author

comaniac commented Jan 9, 2020

@u99127 have you got a chance to review it?

Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac
Copy link
Contributor Author

Should we merge this part first if no one wants to further review it for now?
cc @masahi @tqchen

docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
Copy link
Member

@tqchen tqchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick pass

docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
@masahi
Copy link
Member

masahi commented Jan 16, 2020

waiting for @tqchen's approval

@masahi masahi merged commit ddef940 into apache:master Jan 16, 2020
@masahi
Copy link
Member

masahi commented Jan 16, 2020

thanks @comaniac @zhiics @tqchen

@comaniac comaniac deleted the byoc_dev_guide branch January 16, 2020 22:11
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
* BYOC tutorial: codegen C

* Address comments

* Address comments

* Add build option

* Address comments

* Use TVM_DLL_EXPORT_TYPED_FUNC
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
* BYOC tutorial: codegen C

* Address comments

* Address comments

* Add build option

* Address comments

* Use TVM_DLL_EXPORT_TYPED_FUNC
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
* BYOC tutorial: codegen C

* Address comments

* Address comments

* Add build option

* Address comments

* Use TVM_DLL_EXPORT_TYPED_FUNC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants