[Relay][Legalize] Legalize conv2d_transpose for NHWC #4399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apivovarov
force-pushed
the
conv2d_transpose_legalize
branch
4 times, most recently
from
cf65f02 to
717ac15
Compare
|
@anijain2305 Can you take a look? |
|
@merrymercy Can you have a look as well? |
anijain2305
reviewed
Nov 22, 2019
Comment on lines
+143
to
+146
| elif kernel_layout == 'OIHW': | ||
| # input kernel layout is swapped to IOHW | ||
| # output kernel layout will be IOHW | ||
| pass |
There was a problem hiding this comment.
How about just removing this code?
There was a problem hiding this comment.
I see, this is needed, otherwise legalization wont happen
anijain2305
reviewed
Nov 22, 2019
| # output kernel layout will be IOHW | ||
| pass | ||
| else: | ||
| raise ValueError("Invalid kernel_layout {}".format(kernel_layout)) |
There was a problem hiding this comment.
We can do return None here. That is if some topi schedule supports this particular combination of layouts, it will fallback to that.
Return None basically means legalize does not transform anything.
anijain2305
reviewed
Nov 22, 2019
apivovarov
force-pushed
the
conv2d_transpose_legalize
branch
from
717ac15 to
4efed1a
Compare
apivovarov
force-pushed
the
conv2d_transpose_legalize
branch
from
4efed1a to
2d1bccf
Compare
anijain2305
approved these changes
Nov 22, 2019
|
Thanks @apivovarov |
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Nov 26, 2019
yongwww
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Legalizes conv2d_transpose for NHWC.
I need to compile
palm_detection.tflitemodel from mediapipe.This model uses
TRANSPOSE_CONVop. TFLite models uses NHWC data layout only.In order to add TRANSPOSE_CONV to TFLite frontend I need to Legalize conv2d_transpose for NHWC first.
The fact that weights layout and kernel_layout should have flipped IO is very confusing.
I added comments about it in code.