Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[relay][vm] Reuse allocated device memory #4170

Merged
merged 1 commit into from
Oct 22, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/tvm/runtime/vm.h
Original file line number Diff line number Diff line change
Expand Up @@ -747,6 +747,12 @@ class VirtualMachine : public runtime::ModuleNode {

/*! \brief The parameter name to data mapping. */
std::unordered_map<std::string, ObjectRef> params_;

/*!
* \brief The constant pool for runtime. It caches the device dependent
* object to avoid rellocation of constants during inference.
*/
std::vector<ObjectRef> const_pool_;
};

} // namespace vm
Expand Down
15 changes: 12 additions & 3 deletions src/runtime/vm/vm.cc
Original file line number Diff line number Diff line change
Expand Up @@ -795,9 +795,18 @@ void VirtualMachine::RunLoop() {
}
case Opcode::LoadConst: {
auto constant_obj = exec->constants[instr.const_index];
// TODO(wweic) ctx could be obtained from the ctxs list.
auto device_obj = CopyTo(constant_obj, ctxs[0]);
WriteRegister(instr.dst, device_obj);
// We cache the allocated object in the constant pool. To measure, the
// first iteration will set the pool up. The other iterations will
// directly reuse the allocated objects.
if (const_pool_.size() <= static_cast<size_t>(instr.const_index)) {
const_pool_.resize(instr.const_index + 1);
}

if (!const_pool_[instr.const_index].defined()) {
// TODO(wweic) ctx could be obtained from the ctxs list.
const_pool_[instr.const_index] = CopyTo(constant_obj, ctxs[0]);
}
WriteRegister(instr.dst, const_pool_[instr.const_index]);
pc++;
goto main_loop;
}
Expand Down