Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add more pad_mode support for onnx converter #4029

Merged
merged 2 commits into from
Sep 28, 2019

Conversation

bindog
Copy link
Contributor

@bindog bindog commented Sep 28, 2019

TVM already supports 'edge' and 'reflect' pad_mode for operator Pad.

@zhiics @jroesch @kevinthesun can you help review this?

@@ -1266,7 +1278,6 @@ def test_erf():
test_forward_arg_min_max()
test_softmax()
test_constantfill()
test_pad()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a duplicate test_pad() below, so I remove this line

Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiics zhiics merged commit bbf82e0 into apache:master Sep 28, 2019
@bindog bindog deleted the pad_fix branch September 29, 2019 07:42
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 30, 2019
* [Fix] Add more pad_mode support for onnx converter

* robustness fix
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 30, 2019
* [Fix] Add more pad_mode support for onnx converter

* robustness fix
wweic pushed a commit to neo-ai/tvm that referenced this pull request Oct 1, 2019
* [Fix] Add more pad_mode support for onnx converter

* robustness fix
petrex added a commit to petrex/tvm that referenced this pull request Oct 29, 2019
* master:
  Fix split's last factor issue (apache#4044)
  [COMMUNITY] ajtulloch -> committer (apache#4043)
  [TOPI]Add op argwhere (apache#3994)
  [topi] add ARM v8.2 udot (uint8) support (apache#3978)
  [COMMUNITY] anijain2305 -> reviewer (apache#4036)
  [QNN] Renaming dense operator. (apache#4033)
  [Relay][Compile_engine] Int64 shape handling for outputs. (apache#4031)
  Add dmlc-core to the list of installed header directories. (apache#4035)
  [ARITH] migrate indexdiv/mod to floordiv/mod (apache#4008)
  [Relay] Move prelude to text format (apache#3939)
  make tvm compilable by gcc 4.9.2 (apache#4032)
  [AUTOTVM][DOCS] Add a link to the defining network description of auto-tuning tutorial (apache#4023)
  [ARITH] cleanup the indexmod/div on python side (apache#4028)
  [Fix] Add more pad_mode support for onnx converter (apache#4029)
  Add parser support for ReLU tflite operator (apache#4022)
  Additional MXNet Convolution and Deconvolution tests (apache#4026)
  docs: minor spelling tweaks (apache#4027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants