[Relay] Add gradient for reshape #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarisaKirisame
force-pushed
the
reshape-grad
branch
from
51d704d to
c3596f7
Compare
SWu
reviewed
Sep 6, 2019
| @@ -247,6 +247,7 @@ def verify_reshape(shape, newshape, oshape): | |||
| assert zz.checked_type == relay.ty.TensorType(oshape, "float32") | |||
|
|
|||
| func = relay.Function([x], z) | |||
| check_grad(func) | |||
There was a problem hiding this comment.
I think it might be a good idea to separate this test out since gradient is implemented separately from the op
There was a problem hiding this comment.
This allow us to get the same coverage for both test_op_level3 and test_op_grad_level3. I think we should move toward this style.
There was a problem hiding this comment.
True. I think grad implementations could also use some refactoring to move around; it would be more convenient implementation-wise to put grad implementations next to their forward op implementations as well.
There was a problem hiding this comment.
That also sounds good. Tensor_grad is getting big.
SWu
approved these changes
Sep 6, 2019
jroesch
approved these changes
Sep 6, 2019
MarisaKirisame
added a commit
to MarisaKirisame/tvm
that referenced
this pull request
Sep 7, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.
@SWu @vinx13 @Ruinhuang can you guys help review?