Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArgBinder assert order #3794

Merged
merged 1 commit into from
Aug 17, 2019
Merged

Fix ArgBinder assert order #3794

merged 1 commit into from
Aug 17, 2019

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Aug 16, 2019 •
edited
Loading

Fixed #3793

cc @icemelon9 @mli

cchung100m
cchung100m reviewed Aug 16, 2019
View reviewed changes
Copy link
Contributor

@cchung100m cchung100m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@vinx13 vinx13 merged commit f9d8d06 into apache:master Aug 17, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
@vinx13 @wweic
Fix ArgBinder assert order (apache#3794)
f76e0fe
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
@vinx13 @wweic
Fix ArgBinder assert order (apache#3794)
e1f1766
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 16, 2019
@vinx13 @wweic
Fix ArgBinder assert order (apache#3794)
f43e77d
@yzhliu yzhliu mentioned this pull request Nov 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchung100m cchung100m cchung100m left review comments

@icemelon icemelon icemelon approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only the first shape dim allows to depend on an extra variable
3 participants
@vinx13 @icemelon @cchung100m