Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCKER] Add DGL to {ci_gpu, demo_cpu, demo_gpu} docker images #3692

Merged
merged 2 commits into from
Aug 2, 2019
Merged

[DOCKER] Add DGL to {ci_gpu, demo_cpu, demo_gpu} docker images #3692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc04bb1
add dgl to docker file
yy665 Aug 2, 2019
8d20c53
add dgl to docker file
yy665 Aug 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docker/Dockerfile.ci_gpu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ RUN bash /install/ubuntu_install_tflite.sh
COPY install/ubuntu_install_caffe2.sh /install/ubuntu_install_caffe2.sh
RUN bash /install/ubuntu_install_caffe2.sh

COPY install/ubuntu_install_dgl.sh /install/ubuntu_install_dgl.sh
RUN bash /install/ubuntu_install_dgl.sh

RUN pip3 install Pillow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just add dgl here?

Copy link
Contributor Author

@yy665 yy665 Aug 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just trying to follow the existing convention of installing external frameworks.
FYI please see docker/install/ubuntu_install.mxnet.sh


COPY install/ubuntu_install_vulkan.sh /install/ubuntu_install_vulkan.sh
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.demo_cpu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ RUN echo deb http://apt.llvm.org/xenial/ llvm-toolchain-xenial-6.0 main \
RUN pip3 install matplotlib Image Pillow jupyter[notebook]

# Deep learning frameworks
RUN pip3 install mxnet tensorflow keras gluoncv
RUN pip3 install mxnet tensorflow keras gluoncv dgl

# Build TVM
COPY install/install_tvm_cpu.sh /install/install_tvm_cpu.sh
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.demo_gpu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ RUN echo deb http://apt.llvm.org/xenial/ llvm-toolchain-xenial-6.0 main \
RUN pip3 install matplotlib Image Pillow jupyter[notebook]

# Deep learning frameworks
RUN pip3 install mxnet tensorflow keras gluoncv
RUN pip3 install mxnet tensorflow keras gluoncv dgl

# Build TVM
COPY install/install_tvm_gpu.sh /install/install_tvm_gpu.sh
Expand Down
23 changes: 23 additions & 0 deletions docker/install/ubuntu_install_dgl.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#!/bin/bash
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

set -e
set -u
set -o pipefail

pip3 install dgl