Print llvm source by default in ROCMModuleNode::GetSource #3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @t-vi you can tag me for something ROCm related. I think it is good to merge as is. |
masahi
approved these changes
Jul 30, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Aug 9, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to the LLVM module, which also prints the LLVM IR by default. Currently it just returns an empty string, which is useful in the rarest cases.
The other id that might be worth supporting for compatibility with the other LLVM might be
"ll", but I would check with you first.I briefly looked for a canonical place to add a test, but must admit I didn't really find one. There are some uses of get_source in
tests/python/unittest/test_codegen_*, but those seem to be check very specific things about the generated code rather then whetherModuleworks in general.