-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay][Pass][Docs] Update the doc for adding a Relay pass to mention the pass infra #3583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the doc. Overall looks good to me. Only left some nitpicks.
docs/dev/relay_pass_infra.rst
Outdated
Relay Pass Infra | ||
.. _relay-pass-infra: | ||
|
||
Relay Pass Infrastructure | ||
================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align =
with the header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
cc2a5c2
to
e1d6093
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… the pass infra (apache#3583) * Update the Relay adding pass doc to reference the new pass infrastructure * Correct pass name Co-Authored-By: Zhi <[email protected]> * Align header equals signs
… the pass infra (apache#3583) * Update the Relay adding pass doc to reference the new pass infrastructure * Correct pass name Co-Authored-By: Zhi <[email protected]> * Align header equals signs
Follow-up to issue #3480 and PR #3515: I've updated the existing documentation on writing a Relay pass to reflect the use of the pass infrastructure and to reference the pass infrastructure docs.
Please, if you can, review for accuracy, style, and correctness @zhiics @weberlo @joshpoll and any others who may be knowledgeable