Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Pass][Docs] Update the doc for adding a Relay pass to mention the pass infra #3583

Merged
merged 3 commits into from
Jul 23, 2019

Conversation

slyubomirsky
Copy link
Contributor

Follow-up to issue #3480 and PR #3515: I've updated the existing documentation on writing a Relay pass to reflect the use of the pass infrastructure and to reference the pass infrastructure docs.

Please, if you can, review for accuracy, style, and correctness @zhiics @weberlo @joshpoll and any others who may be knowledgeable

Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the doc. Overall looks good to me. Only left some nitpicks.

docs/dev/relay_add_pass.rst Outdated Show resolved Hide resolved
Relay Pass Infra
.. _relay-pass-infra:

Relay Pass Infrastructure
==================================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align = with the header?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

@slyubomirsky slyubomirsky force-pushed the relay-add-pass-update branch from cc2a5c2 to e1d6093 Compare July 23, 2019 00:50
Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiics zhiics merged commit 9911044 into apache:master Jul 23, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Aug 9, 2019
… the pass infra (apache#3583)

* Update the Relay adding pass doc to reference the new pass infrastructure

* Correct pass name

Co-Authored-By: Zhi <[email protected]>

* Align header equals signs
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
… the pass infra (apache#3583)

* Update the Relay adding pass doc to reference the new pass infrastructure

* Correct pass name

Co-Authored-By: Zhi <[email protected]>

* Align header equals signs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants