[Relay][Quantization] Fix add_rewrite and UnifyDTypeScale #3534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmoreau89
approved these changes
Jul 11, 2019
|
@ZihengJiang can you review this PR before I merge it? |
tqchen
approved these changes
Jul 12, 2019
ZihengJiang
reviewed
Jul 17, 2019
| LOG(FATAL) << "should not touch here."; | ||
| dtype = cfg->dtype_activation; | ||
| } | ||
| for (size_t i = 0; i < ret.size(); ++i) { |
There was a problem hiding this comment.
Hey @vinx13 , I guess we can remove this part with rewrite_for_vta, which will insert cast and stop_fusion in the end of residual block
There was a problem hiding this comment.
@ZihengJiang This part is needed when rewrite_for_vta is not enabled (store_lowbit_output=False), or we can remove this part in rewrite_for_vta?
There was a problem hiding this comment.
@vinx13 Current Realize pass has been used to achieve multiple goals: insert stop_fusion; decide datatype; unify scales for some operator, etc. It's better to decouple things for passes, I would also like to make rewrite_for_vta and store_lowbit_output enabled by default.
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Aug 9, 2019
* [Relay][Quantization] Fix issue introduced in apache#3135 * Recover StopFusion * Fix fmultiref * Fix lint
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
* [Relay][Quantization] Fix issue introduced in apache#3135 * Recover StopFusion * Fix fmultiref * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed a few broken things due to previous changes:
UnifyDTypeScaleForwardRewriteargumentsrelay._quantize.annotate(we moved to mod api)See https://discuss.tvm.ai/t/quantization-broken-due-to-pr-3135/3237/6
cc @ZihengJiang @tmoreau89