Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QNN] Requantize operator #3531
[QNN] Requantize operator #3531
Changes from all commits
847dd52
ed11cd7
91b58a5
13fcc70
ac4dfdc
01cad3a
6405755
7a49bee
154e64f
324e75c
ffec47f
72436ff
9a721ad
fb9cece
be7101f
0a5642a
a9c1ce0
a0d0324
513b544
435ca27
e4f6a4e
10a20d3
927825d
48f5a52
1422f6d
66a4d76
99483c2
f8439e6
e756843
5d7938f
10ce99d
f2e09d1
65c0b46
8d2c3ad
2d15b54
ff17a91
c46b56c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double check the choice of enums "TONEAREST", are there existing API choices that are similar? I do not have preference but would be great to survey the related APIs should it be "TO_NEAREST"? (The TF API convention seems to be TO_NEAREST)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had similar question while coding this. I used TONEAREST because the supporting document - https://www.gnu.org/software/libc/manual/html_node/Rounding.html
had FE_TONEAREST. To be consistent with that document, I kept TONEAREST. But, I like TO_NEAREST better as it aligns with the rest of the codebase.