[CI] Fix shell script exit codes #3329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exist code of a posix compilant shell is 0..255. Attempting to return -1 will error in some shells and implicitly cast to 255 in others. Fix it by returning a legal return value.
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
The exist code of a posix compilant shell is 0..255. Attempting to return -1 will error in some shells and implicitly cast to 255 in others. Fix it by returning a legal return value.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
The exist code of a posix compilant shell is 0..255. Attempting to return -1 will error in some shells and implicitly cast to 255 in others. Fix it by returning a legal return value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exist code of a posix compilant shell is 0..255. Attempting to
return -1 will error in some shells and implicitly cast to 255 in
others. Fix it by returning a legal return value.