[LINT] Improve robustness in task_lint.sh logic #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing RAT ASF license auditing logic ignores any failure in the shell pipeline rather than just the exit code of the final grep. Adjust the logic such that failure of the various tools in the pipeline are not elided away.
tqchen
approved these changes
Jun 7, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
The existing RAT ASF license auditing logic ignores any failure in the shell pipeline rather than just the exit code of the final grep. Adjust the logic such that failure of the various tools in the pipeline are not elided away.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
The existing RAT ASF license auditing logic ignores any failure in the shell pipeline rather than just the exit code of the final grep. Adjust the logic such that failure of the various tools in the pipeline are not elided away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing RAT ASF license auditing logic ignores any failure in the
shell pipeline rather than just the exit code of the final grep.
Adjust the logic such that failure of the various tools in the
pipeline are not elided away.