More fixes and tweaks to the cuda conda packages #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @abergeron for the contribution! Yes, a CI script that verifies the build will be nice. One question about the docker env. We normally use https://github.com/dmlc/tvm/tree/master/docker as a way to cache pre-built docker images so we don't have to build again and avoids some problems when there is an upstream change, can we also do that in conda packaging? |
|
It would certainly be possible to adapt my build scripts to generate the GPU docker images and pre-build them. As for the CPU packages they are currently built as-is, but I could make a docker image for that too. I can add that to this PR or make a new one. |
|
a new PR would be great since we build and cache the docker images |
|
Thanks, @abergeron , this PR is now merged |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings some fixes to the conda cuda build so that it works once again.
I've also added support for cudnn in those packages since anaconda started packaging it.
There should really be a phase in the tests that builds the packages. If there is interest I can make an attempt at adding that to the Jenkinsfile.