[Relay/TOPI][Op] Add TopK operator #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icemelon
changed the title
yongwww
requested changes
May 30, 2019
| The input data tensor. | ||
|
|
||
| k : int, optional | ||
| Number of top elements to select. Return all elements if k < 1. |
There was a problem hiding this comment.
recommend returning a tensor with size 0 if k==0
There was a problem hiding this comment.
I think current graph runtime doesn't support 0 size tensor. So I assert k >= 1 in tensorflow frontend converter.
yongwww
requested changes
May 30, 2019
|
Have you compared you current sort implementation with existing one? Is there any performance regression for large workloads like (1, 8000) |
|
@Laurawly I evaluated the CUDA performance of argsort with input size (1, 8000) on p3. Existing one take 28.57ms to finish, and the one in this PR takes 15.11ms. |
yzhliu
approved these changes
Jun 4, 2019
Laurawly
approved these changes
Jun 4, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
* init impl for topk * Fix cpu for topk * init cuda impl for topk * Add cuda for topk * fix * Add doc * update doc * lint * lint * lint * x * fix warning * [Relay] Add TopK in tf converter * Add frontend converter * fix
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
* init impl for topk * Fix cpu for topk * init cuda impl for topk * Add cuda for topk * fix * Add doc * update doc * lint * lint * lint * x * fix warning * [Relay] Add TopK in tf converter * Add frontend converter * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes
Thanks @yongwww for help on Tensorflow frontend converter.