[Relay][RFC] Implement type checking for Any #3221

jroesch · 2019-05-21T20:21:42Z

Currently a draft PR, see related RFC #3042.

This PR will only contain the type checking changes to Relay to support Any. @icemelon9 and I will follow up with the related code generation PRs.

python/tvm/relay/__init__.py

python/tvm/relay/expr.py

src/relay/pass/type_infer.cc

src/relay/pass/type_solver.cc

wweic

first pass on debugging prints mostly. overall lgtm.

wweic · 2019-06-24T20:38:43Z

include/tvm/relay/attrs/transform.h

  DataType dtype;

  TVM_DECLARE_ATTRS(ArangeAttrs, "relay.attrs.ArangeAttrs") {
-    TVM_ATTR_FIELD(start).set_default(make_const(Float(32), 0))


why removing the defaults?

We can't easily make Relay constant values in C++.

python/tvm/relay/__init__.py

python/tvm/relay/scope_builder.py

tests/python/relay/test_any.py

src/relay/pass/type_infer.cc

src/relay/op/tensor/transform.cc

src/relay/pass/type_solver.cc

include/tvm/relay/op_attr_types.h

python/tvm/relay/loops.py

src/relay/ir/type.cc

src/relay/op/tensor/transform.cc

src/relay/op/type_relations.cc

Remove code generation related changes Remove compile changes Remove more Remove unification hack Add some code back that was needed, and clean up test Refactor test cases WIP Implement TypeHint AST Add test case which should fail Remove unification changes, and fix bug with let rec Restore unification for shapes Improve error reporting while debugging All examples type check All examples type check WIP First version that works with hints, needs clean up Remove dead code Tweaks Remove type hint Remove unecessary type hint stuff Remove more type hints Clean up Expose Any expression node Address CR Fix Fix solver Kill unecessary code Fix PyLint Fix Relocate loops Fix license and test Lint again Lint again Fix loops Fix docstring Fix template error Fix compiler issue Fix compile err Remove more runtime changes Restore buffer Fix segfault Fix Fix arange

include/tvm/relay/expr.h

tests/python/relay/test_op_level3.py

MarisaKirisame · 2019-07-03T08:03:32Z

src/relay/pass/type_solver.cc


-    auto mod = [solver](std::string name) -> PackedFunc {
+    auto mod = [solver, err_reporter](std::string name) -> PackedFunc {


BAD! This will never get free!
use a shared_ptr!

Its fine, this is testing code dude

wweic

lgtm.

wweic · 2019-07-07T16:45:31Z

src/lang/tensor.cc

-  CHECK_EQ(ndim(), indices.size())
-      << "Tensor dimension mismatch in read"
-      << "ndim = " << ndim() << ", indices.size=" << indices.size();
+  if (ndim() != 0) {


Why add ndim() != 0 here?

This is to allow retrieval of the "first" element from scalars.

tmoreau89 · 2019-07-07T23:31:55Z

include/tvm/relay/op_attr_types.h

@@ -158,6 +158,22 @@ using FForwardRewrite = runtime::TypedPackedFunc<
 using FPrimalGradient = runtime::TypedPackedFunc<tvm::Array<Expr>(const Expr& orig_call,
                                                                  const Expr& output_grad)>;

+/*!
+ * \brief The codegeneration strategy for dynamic dimensions.


code generation

tmoreau89 · 2019-07-07T23:34:27Z

src/relay/ir/pretty_printer.cc

@@ -664,7 +664,9 @@ class PrettyPrinter :
  Doc PrintAttr(const NodeRef& value, bool meta = false) {
    if (value.defined()) {
      Doc printed_attr;
-      if (meta) {
+      if (value.as<tvm::ir::Any>()) {
+        printed_attr << "?";


could this be ambiguous? why not print "any"

I kind of like ? instead of any because the shape will still be checked dynamically, so even though we're calling the node "any," not literally any shape will work

tmoreau89 · 2019-07-07T23:44:48Z

tests/python/relay/test_any.py

+    func = relay.Function([start], relay.TupleGetItem(body, 1))
+    func = infer_type(func)
+    # TODO(@jroesch, @haichen): We should restore this code when codegeneration
+    # is merged


is there a PR we can reference?

* Implement type checking for Any Remove code generation related changes Remove compile changes Remove more Remove unification hack Add some code back that was needed, and clean up test Refactor test cases WIP Implement TypeHint AST Add test case which should fail Remove unification changes, and fix bug with let rec Restore unification for shapes Improve error reporting while debugging All examples type check All examples type check WIP First version that works with hints, needs clean up Remove dead code Tweaks Remove type hint Remove unecessary type hint stuff Remove more type hints Clean up Expose Any expression node Address CR Fix Fix solver Kill unecessary code Fix PyLint Fix Relocate loops Fix license and test Lint again Lint again Fix loops Fix docstring Fix template error Fix compiler issue Fix compile err Remove more runtime changes Restore buffer Fix segfault Fix Fix arange * Address feedback * Fix typo * Fix arange * Fix op level3 * Fix issue with Python wrapper

jroesch force-pushed the any-tc branch from 1acbdcd to 93add4b Compare May 23, 2019 09:41