[RELAY][PASS] detect depthwise conv2d in mac_count pass #3083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
requested changes
Apr 24, 2019
eqy
added
status: need review
and removed
status: need update
merrymercy
reviewed
May 5, 2019
src/relay/pass/mac_count.cc
Outdated
| int64_t count = input_channel * GetCartesianProd(output_tensor) * GetCartesianProd(kernel_size); | ||
| << "The dimension of the output tensor in Conv 2D should be 4 or 5."; | ||
| int64_t count = GetCartesianProd(output_tensor) * GetCartesianProd(kernel_size); | ||
| if (!depthwise) { |
There was a problem hiding this comment.
We don't need this. This branch is also true for depthwise conv2d
|
Any updates? Is the general group conv2d supported? We should probably try to get it merged before it start to bitrot |
merrymercy
approved these changes
May 14, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
* check in * use groups * CHECK_EQ * trigger CI * Update mac_count.cc * trigger CI * trigger CI
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
* check in * use groups * CHECK_EQ * trigger CI * Update mac_count.cc * trigger CI * trigger CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before mobilenet1.0 was counted as over 4G MACs, now it is ~500M MACs.