[TOPI] Rename output tensors for better readability #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
force-pushed
the
pr-topi-names
branch
from
df73bf9 to
ac4c182
Compare
|
Please fix the lint error. @sgrechanik-h please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly |
sgrechanik-h
suggested changes
Apr 19, 2019
| @@ -1106,7 +1106,7 @@ inline Tensor arange(const Expr start, | |||
| inline Tensor layout_transform(const Tensor& src, | |||
| const std::string& src_layout, | |||
| const std::string& dst_layout, | |||
| const std::string name = "layout_transform", | |||
| const std::string name = "T_layout_trans", | |||
There was a problem hiding this comment.
Suggested change
| const std::string name = "T_layout_trans", | |
| const std::string name = "T_layout_transform", |
There was a problem hiding this comment.
For unambiguous long names, I would like abbreviations.
sgrechanik-h
approved these changes
Apr 20, 2019
|
Thanks @sgrechanik-h , @merrymercy this is now merged! |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current topi uses "tensor" as the name of output tensors.
This PR changes the names to more meaningful names for easier debugging.
cc @xqdan @sgrechanik-h