-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay][OP] Gather_nd exposed to relay #2945
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ad47856
gather_nd added
Laurawly ec3086b
gather_nd test added
Laurawly 1e5db89
more test added
Laurawly 9381c2c
fix lint
Laurawly e08bcc2
fix build error
Laurawly ea363aa
fix lint
Laurawly 29924a4
comments addressed
Laurawly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# pylint: disable=invalid-name, import-self, len-as-condition | ||
# pylint: disable=invalid-name, import-self, len-as-condition, unused-argument | ||
"""MXNet symbol frontend.""" | ||
from __future__ import absolute_import as _abs | ||
|
||
|
@@ -631,6 +631,11 @@ def _mx_deformable_convolution(inputs, attrs): | |
return res | ||
|
||
|
||
def _mx_gather_nd(inputs, attrs): | ||
assert len(inputs) == 2 | ||
return _op.gather_nd(inputs[0], inputs[1]) | ||
|
||
|
||
# Note: due to attribute conversion constraint | ||
# ops in the identity set must be attribute free | ||
_identity_list = [ | ||
|
@@ -768,6 +773,7 @@ def _mx_deformable_convolution(inputs, attrs): | |
"SoftmaxOutput" : _mx_softmax_output, | ||
"SoftmaxActivation" : _mx_softmax_activation, | ||
"smooth_l1" : _mx_smooth_l1, | ||
"gather_nd" : _mx_gather_nd, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can put gather_nd in the _identity_list. |
||
# vision | ||
"_contrib_BilinearResize2D" : _mx_upsampling, | ||
"_contrib_MultiBoxPrior" : _mx_multibox_prior, | ||
|
@@ -782,7 +788,6 @@ def _mx_deformable_convolution(inputs, attrs): | |
# TODO(tvm-tvm): support all operators. | ||
# | ||
# "broadcast_to", | ||
# "gather_nd", | ||
# "Crop" : _crop_like, | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need to disable this pylint if you put gather_nd in the identity_list