-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend][TF] Fix Placeholder issue #2834
Conversation
e053e52
to
c358f4d
Compare
@yongwww Can you add a small regression test to tests/python/frontend/tensorflow/test_forward.py to prevent the problem from happening again? |
@kazum sure, I'll add a test case with a small code snippet or a small .pb graphdef |
@yongwww Anyway this change is good to have. |
@srkreddy1238 yeah, the graphdef is kind of weird, but it should be valid, probably caused by ProtocolBuffer. We also met this issue when handling control flow stuff since there are cycles in graph, which makes topological ordering behave abnormally. |
78a2cde
to
1a43d06
Compare
@yongwww, can you fix the CI error? |
@kazum I am working on it, will update soon |
@kazum test case should be okay, works on my local env. In order to pass CI, need to get the pb file (dmlc/web-data#172) uploaded first, could you please take a look at the PRs |
Thanks @yongwww @srkreddy1238. This is now merged. |
* [Frontend][TF] Fix Placeholder issue * Add test cases
* [Frontend][TF] Fix Placeholder issue * Add test cases
This pr is a fix for issue "Math op expect 2 inputs, 1 given" in tf frontend. This frozen pb in the repo can be used to reproduce this issue. The placeholder node is at the end of the graphdef for some reason, so we need to preprocess these ops during first traversal before they are used.
@srkreddy1238 @wweic @kazum please take a look.