[Relay][Frontend] Add reverse op to relay #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icemelon
requested changes
Mar 12, 2019
include/tvm/relay/attrs/transform.h
Outdated
| TVM_ATTR_FIELD(axis).set_default(NullValue<Integer>()) | ||
| .describe(" The axis along which to reverse elements."); | ||
| } | ||
| }; // struct RepeatAttrs |
tests/python/relay/test_op_level3.py
Outdated
| intrp = relay.create_executor(kind, ctx=ctx, target=target) | ||
| op_res = intrp.evaluate(func)(x_data) | ||
| tvm.testing.assert_allclose(op_res.asnumpy(), ref_res, rtol=1e-5) | ||
| verify_reverse((2, 3, 4), 1 ) |
src/relay/op/tensor/transform.cc
Outdated
| const auto* param = attrs.as<ReverseAttrs>(); | ||
| const int ndim = static_cast<int>(data->shape.size()); | ||
| const int axis = param->axis; | ||
| CHECK(-ndim - 1 <= axis && axis <= ndim) |
src/relay/op/tensor/transform.cc
Outdated
| } | ||
|
|
||
| Expr MakeReverse(Expr data, | ||
| int axis) { |
include/tvm/relay/attrs/transform.h
Outdated
| Integer axis; | ||
| TVM_DECLARE_ATTRS(ReverseAttrs, "relay.attrs.ReverseAttrs") { | ||
| TVM_ATTR_FIELD(axis).set_default(NullValue<Integer>()) | ||
| .describe(" The axis along which to reverse elements."); |
python/tvm/relay/op/transform.py
Outdated
| The axis along which to reverse elements. | ||
|
|
||
| .. note:: | ||
| Reverse and flip are equivalent. |
There was a problem hiding this comment.
I don't think we need this note since we don't have flip op in Relay.
python/tvm/relay/op/transform.py
Outdated
| -------- | ||
| .. code-block:: python | ||
|
|
||
| x = [[1, 2], [3, 4]] |
There was a problem hiding this comment.
Use float value to be consistent
src/relay/op/tensor/transform.cc
Outdated
| for (int i = 0; i < ndim; ++i) { | ||
| oshape.emplace_back(data->shape[i]); | ||
| } | ||
| reporter->Assign(types[1], TensorTypeNode::make(oshape, data->dtype)); |
There was a problem hiding this comment.
You can directly use reporter->Assign(types[1], types[0]);. No need to create oshape.
icemelon
approved these changes
Mar 12, 2019
src/relay/op/tensor/transform.cc
Outdated
| const auto* param = attrs.as<ReverseAttrs>(); | ||
| const int ndim = static_cast<int>(data->shape.size()); | ||
| const int axis = param->axis; | ||
| CHECK(-ndim - 1 < axis && axis < ndim) |
There was a problem hiding this comment.
We can just use -ndim <= axis to simplify the expr.
|
Thanks @Laurawly. This is now merged. |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Mar 20, 2019
* start adding reverse * reverse updated * reverse uses topi::flip * typo fixed * comment addressed * exp simplified
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 20, 2019
* start adding reverse * reverse updated * reverse uses topi::flip * typo fixed * comment addressed * exp simplified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.