Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cpptest build on Ubuntu #2798

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Make cpptest build on Ubuntu #2798

merged 1 commit into from
Mar 12, 2019

Conversation

apivovarov
Copy link
Contributor

@apivovarov apivovarov commented Mar 12, 2019

Changes in code:

  1. add dl to target_link_libraries in CMakeLists.txt for Tests to solve undefined reference to dl* issue
libtvm.so: undefined reference to `dlopen'
libtvm.so: undefined reference to `dlclose'
libtvm.so: undefined reference to `dlerror'
libtvm.so: undefined reference to `dlsym'

https://discuss.tvm.ai/t/make-cpptest-failed

Changes in docs:

  1. add apt command to install gtest
  2. Add USE_LLVM=ON param to cmake because llvm target should be enabled for one of the tests
  3. replace make -j with make -j$(nproc) because just -j starts building for all files in parallel (list of files is quite big).
  4. remove || exit -1 from test loop.
    exit -1 makes it exists from the shell where you run the command in case of test failure.
    We might want to break the loop but not to exist from the shell.
    Anyway, usual junit practice is to run all tests and check the results.

@kevinthesun kevinthesun requested a review from tqchen March 12, 2019 20:20
@tqchen tqchen merged commit 864da84 into apache:master Mar 12, 2019
@apivovarov apivovarov deleted the cpptest branch March 12, 2019 23:44
wweic pushed a commit to wweic/tvm that referenced this pull request Mar 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants