[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also @yongwww & @ashutoshparkhi welcome to review |
commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution
kazum
reviewed
Mar 12, 2019
kazum
requested changes
Mar 12, 2019
yongwww
requested changes
Mar 12, 2019
| @@ -1267,15 +1369,22 @@ def from_tensorflow(self, graph, layout="NHWC", shape=None, outputs=None): | |||
| elif shape and node.name in shape: | |||
| # Give priority to user argument. | |||
| self._output_shapes[node.name] = [shape[node.name]] | |||
| elif node.op == 'Placeholder': | |||
There was a problem hiding this comment.
Actually the change here was merged with pr #2493. It is okay to ignore the following three commits since #2493 was merged.
commit f347b52
Author: Yong Wu [email protected]
Get tags of saved model automatically
commit 916576c
Author: Zhi Chen [email protected]
Support TensorFlow saved model
TF parser: return the consistent error message to error handler
commit f1782f3
Author: Yong Wu [email protected]
Add tf parser wrapper, infer shape automatically
There was a problem hiding this comment.
You are right. Removed now.
|
@srkreddy1238 please send another push to re-trigger CI. @yongwww please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Mar 20, 2019
…che#2757) * [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution * * review comments * * resnet fix. * * review comments
| # This means the node is 1d in Relay and 0d in TF. | ||
| # See `_expand_dims_0d_aware`. | ||
| if self._outputs_are_0d[node_name][tensor_slot] and input_shape: | ||
| input_0d_mismatch.add(in_sym) |
There was a problem hiding this comment.
Shouldn't this be in_sym[tensor_slot]?
There was a problem hiding this comment.
I think tensor_slot us already handled above.
There was a problem hiding this comment.
In my variant of inception_v3, in_sym comes as a list of Var instead of _expr.TupleWrapper.
There was a problem hiding this comment.
@ashutoshparkhi will fix it in pr #2830
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 20, 2019
…che#2757) * [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution * * review comments * * resnet fix. * * review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 76188a4
Author: Siva [email protected]
[NNVM][TENSORFLOW] bugfix. (#2444)
commit 6737739
Author: Ashutosh Parkhi [email protected]
[Tensorflow] Support for Crop (#2285)
commit f6c3f99
Author: Alexey Romanov [email protected]
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (#2242)
commit e5d92e1
Author: Dominic Symes [email protected]
[FRONTEND][TENSORFLOW] Bugfix (#2326)
commit 00d509d
Author: Alexey Romanov [email protected]
[FRONTEND][TENSORFLOW] Support Unstack and Split (#2105)
commit df9d3ad
Author: Siva [email protected]
[FRONTEND][TENSORFLOW] Bugfix (#2267)
commit d1a0c90
Author: Zhebin Jin [email protected]
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.