Improve NNVM to Relay conversion #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
reviewed
Mar 5, 2019
| @@ -441,6 +443,23 @@ def check_function(symbol, forward=None, backward=None, grad_input_vars=None, | |||
| debug_stage = "running" | |||
| nnvm_res = main_function(**np_inputs) | |||
|
|
|||
| try: | |||
| logging.debug("checking to_relay conversion") | |||
There was a problem hiding this comment.
Will this print every time this code is executed?
There was a problem hiding this comment.
I think it depends on the logging configuration, but, with our CI, this message will be printed only when an error occurs.
|
Overall looks good, I could swear their were more tests written by me, but I think were moved/removed during someone's overhaul of the tests. |
jroesch
approved these changes
Mar 8, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 9, 2019
* Improve NNVM to Relay conversion * fix pylint * support __lshift_scalar__, abs, ceil, floor, and trunc to pass CI
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
* Improve NNVM to Relay conversion * fix pylint * support __lshift_scalar__, abs, ceil, floor, and trunc to pass CI
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
* Improve NNVM to Relay conversion * fix pylint * support __lshift_scalar__, abs, ceil, floor, and trunc to pass CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to_relay() checks to our NNVM tests. This PR also includes some cleanups of to_relay, fixes of detected bugs, and supports of some operators to pass the test.
@jroesch @yzhliu @grwlf please help review the PR.