use LLVM linker #2713
Merged
use LLVM linker #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, can we raise a friendly error message to ask the user to install lld-link if it is not available? |
|
@mnboos can you improve it a bit according to the comment? :) |
|
Yes, I can do it next week. |
|
Okay, the error message should now be more helpful. |
tqchen
approved these changes
Mar 5, 2019
bwasti
pushed a commit
to facebookexperimental/tvm
that referenced
this pull request
Mar 6, 2019
* use LLVM linker * error message improved in case of filenotfound * linting error fixed
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 9, 2019
* use LLVM linker * error message improved in case of filenotfound * linting error fixed
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
* use LLVM linker * error message improved in case of filenotfound * linting error fixed
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
* use LLVM linker * error message improved in case of filenotfound * linting error fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
export_library()functionality under Windows by using the LLVM linkerlld-linkinstead of the Microsoft linkerlink.See: #2450