Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TFLite][Python 2] Solve TFLite frontend python 2 compatibility #2529

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

FrozenGene
Copy link
Member

@FrozenGene FrozenGene commented Jan 30, 2019

When use Python 2 to compile TFLite model will raise Check failed: width1 != nullptr error. The root cause is Python 2'smath.ceil return float, but Python 3 return int.

Python 2: https://docs.python.org/2.7/library/math.html#math.ceil
Python 3: https://docs.python.org/3.6/library/math.html#math.ceil

This changeset also modify the doc's TFLite whl file download path. Previous path is not raw and will get HTML file.

@yzhliu Please review and could this changeset be into 0.5 release? Thanks.

@tqchen tqchen merged commit da972bd into apache:master Jan 31, 2019
@tqchen
Copy link
Member

tqchen commented Jan 31, 2019

Thanks @FrozenGene , this is now merged

libing4752 pushed a commit to libing4752/tvm that referenced this pull request Feb 18, 2019
merrymercy pushed a commit to merrymercy/tvm that referenced this pull request Feb 18, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
@FrozenGene FrozenGene deleted the tflite_python2_fix branch September 10, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants