Code

[Relay] Algebraic data types#2442

Code

Merged

ZihengJiang merged 61 commits intoapache:masterapache/tvm:masterfrom slyubomirsky:relay-adtslyubomirsky/tvm:relay-adtCopy head branch name to clipboardFeb 16, 2019

+3,398-207

Commits

Commits on Feb 15, 2019

• First pass on ADTs

  

  MarisaKirisame

  authored and

  slyubomirsky

  committed
  f3b58c3

• Add doc string for tag field

  slyubomirsky

  committed
  485889d

• Visit constructors in TypeVisitor for TypeData

  slyubomirsky

  committed
  54e5196

• Add to description of type call

  slyubomirsky

  committed
  671f615

• Add type call to type solving and unification

  slyubomirsky

  committed
  f9e48e8

• Make type mutator for typecall consistent with others (only create new node if there's a change)

  slyubomirsky

  committed
  94748c1

• Ensure kindchecking can handle type calls and typedata

  slyubomirsky

  committed
  7b1126f

• Fix bad nesting in module constructor

  slyubomirsky

  committed
  f2d36d6

• Correctly construct call in typecall test

  slyubomirsky

  committed
  7dc26ef

• Add call override for ordinary vars (do we want this?)

  slyubomirsky

  committed
  0c949c7

• Remove generalization hack from type inference because it was breaking ADT constructors

  slyubomirsky

  committed
  9443bdc

• Check that there are no free type vars in exprs after inferring type

  slyubomirsky

  committed
  33fc344

• Free var checks need module because of ADT constructors

  slyubomirsky

  committed
  c208071

• Typecall test can't have unbound type var, make it global

  slyubomirsky

  committed
  af7da11

• Uncomment tmap test and remove comments about failing to infer ret type; those work now

  slyubomirsky

  committed
  4968b48

• Put in dummy visits for ADTs in graph runtime codegen to placate pylint

  slyubomirsky

  committed
  87f82b7

• Fix Relay type infer test module constructor

  slyubomirsky

  committed
  e0f4c08

• Mark override for TypeCallNode in type solver

  slyubomirsky

  committed
  b646740

• Ensure free vars check treats patern vars as bound

  slyubomirsky

  committed
  e11f58e

• Run interpreter in more ADT test cases

  slyubomirsky

  committed
  ec56e4a

• Refactor kind check to return the kind, like typechecking

  slyubomirsky

  committed
  4f74545

• Fix invalid typecall in test

  slyubomirsky

  committed
  276e028

• Add kind check to type inference, do not use nulls in func_type_annotation()!

  slyubomirsky

  committed
  7963e7e

• Redundant whitespace

  slyubomirsky

  committed
  e2d6219

• Make TypeData a separate kind

  slyubomirsky

  committed
  40c7410

• Make ADT handles a separate kind too, document calling convention better

  slyubomirsky

  committed
  673bcd6

• Remove nats and tree from prelude, move to test, document prelude

  slyubomirsky

  committed
  5e61378

• Restore and document nat and tree to prelude, add more tree tests

  slyubomirsky

  committed
  3db3c64

• Add alpha equality tests for match cases, fix variable binding bug

  slyubomirsky

  committed
  0041b46

• Add more kind check tests for ADTs

  slyubomirsky

  committed
  d232beb

• Add more tests for finding free or bound vars in match exprs

  slyubomirsky

  committed
  7c6d737

• Add unification tests for type call

  slyubomirsky

  committed
  7322866

• Update main() for alpha equality tests

  slyubomirsky

  committed
  5f3a2f4

• Add simple type inference test cases for match exprs and ADT constructors

  slyubomirsky

  committed
  90ee405

• Add more ADT interpreter tests

  slyubomirsky

  committed
  d4a54a1

• Allow incomplete types when typechecking match cases

  slyubomirsky

  committed
  609f56e

• Type inference for pattern vars should use the type annotation if it's there

  slyubomirsky

  committed
  089813a

• Two more specific test cases for ADT matching

  slyubomirsky

  committed
  ebec99c

• Add option ADT to prelude

  slyubomirsky

  committed
  00963de

• Fix broken reference to kind enum

  slyubomirsky

  committed
  47babdb

• Fix rebase snags

  slyubomirsky

  committed
  a37d927

• Do not attach checked types to constructors

  slyubomirsky

  committed
  0c660aa

• More docstrings for module fields

  slyubomirsky

  committed
  f5cec3e

• Use proper wrapper for indexing into module type data

  slyubomirsky

  committed
  b56bc36

• checked_type for constructors is not populated

  slyubomirsky

  committed
  6b8dbb8

• Expand type call docstring

  slyubomirsky

  committed
  07ea915

• Rename PatternConstructor con field

  slyubomirsky

  committed
  b7cfc59

• Use error reporter for pattern constructor case

  slyubomirsky

  committed
  8cd15f2

• Condense error reporting in kind check, use error reporter

  slyubomirsky

  committed
  1d9ae48

• Expand docstrings and rename ADT fields

  slyubomirsky

  committed
  acc2ec0

• Rename 'option' ADT to 'optional' for consistency with Python

  slyubomirsky

  committed
  737514b

• Add various list iterators and utility functions to prelude

  slyubomirsky

  committed
  1a6e48a

• Add smoke tests for new iterators in prelude

  slyubomirsky

  committed
  511a931

• Add concat to prelude

  slyubomirsky

  committed
  3eeca4c

• Add smoke test for concat

  slyubomirsky

  committed
  868f76e

• Correct docstrings in prelude

  slyubomirsky

  committed
  5a85aa8

• Ensure that type defs are written in module initialization

  slyubomirsky

  committed
  bd9bfc7

• Various requested renamings

  slyubomirsky

  committed
  de7ea6e

• Correct rebase snags

  slyubomirsky

  committed
  8909e18

• Add kind check tests for ref types

  slyubomirsky

  committed
  ffd5c80

• Update the main() for kind checking tests

  slyubomirsky

  committed
  7a6eff0