[Relay] A Normal Form Canonicalization #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jroesch is this what you need? |
|
@siju-samuel @vinx13 @srkreddy1238 please review. |
|
@MarisaKirisame Given that there are many possible ways to convert Graph to ANF, can you first send an RFC to propose the "normal form" of conversion? We'd better document it properly. |
MarisaKirisame
force-pushed
the
to_anf
branch
from
6ae8ab6 to
63ad4b7
Compare
MarisaKirisame
force-pushed
the
to_anf
branch
from
dbe90d1 to
63270a2
Compare
|
@vinx13 @srkreddy1238 @tqchen can you guys give one round of review? i had resolved the issues and added more test. |
vinx13
requested changes
Jan 2, 2019
vinx13
approved these changes
Jan 5, 2019
tqchen
requested changes
Jan 5, 2019
tqchen
requested changes
Jan 11, 2019
tqchen
requested changes
Jan 11, 2019
MarisaKirisame
force-pushed
the
to_anf
branch
from
107a0a5 to
464fe86
Compare
tqchen
requested changes
Jan 11, 2019
tqchen
requested changes
Jan 11, 2019
MarisaKirisame
force-pushed
the
to_anf
branch
2 times, most recently
from
f9e8665 to
028f49a
Compare
MarisaKirisame
force-pushed
the
to_anf
branch
from
327d8d1 to
8d4698e
Compare
|
@ZihengJiang can you review? |
tqchen
requested changes
Jan 18, 2019
| * | ||
| * \return expression in A Normal Form | ||
| */ | ||
| Expr ToANF(const Expr& e, const Module& mod); |
There was a problem hiding this comment.
Let use use ToANormalForm, so everyone can google and find out what is ANF
There was a problem hiding this comment.
What about the python side? It wa to_anf.
|
@junrushao1994 @ZihengJiang can you help review this PR? |
|
Will do tonight |
junrushao
reviewed
Jan 18, 2019
Co-Authored-By: MarisaKirisame <[email protected]>
Co-Authored-By: MarisaKirisame <[email protected]>
Co-Authored-By: MarisaKirisame <[email protected]>
tqchen
approved these changes
Jan 24, 2019
|
Thanks, @MarisaKirisame @junrushao1994 ! this is now merged |
tqchen
added
status: accepted
and removed
status: need update
Anthony-Mai
pushed a commit
to Anthony-Mai/tvm
that referenced
this pull request
Jan 25, 2019
zhiics
pushed a commit
to zhiics/tvm
that referenced
this pull request
Jan 30, 2019
Closed
merrymercy
pushed a commit
to merrymercy/tvm
that referenced
this pull request
Feb 18, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr convert any code in graph_normal_form (has sharing in internal AST) into a_normal_form.